Total Profit of all Positions by Label

Jiggy

Hi,
Could you please give an example of how I may put into code:

Close all Buy Positions with Label "myLabel" if the Net Profit TOTAL of these positions >= X

Sorry for the noob question, I have just started to learn C# and cAlgo. I have been trading for a few years.
Thanks.

Mike

Hi, Jiggy,

This is the perfect type of question for this forum, please find your answer below, it was implemented in the simplest form for you to understand, but the code could also have been written with fewer lines of code.

protected override void OnTick()
{
    // this will get all positions with the same label
    var positions = Positions.FindAll("my-label");

    // get all positions that are trade type buy
    var buyPositions = positions.Where(x => x.TradeType == TradeType.Buy);

    // this uses LINQ and lambda expressions to get the sum total of net profit
    double totalProfit = buyPositions.Sum(x => x.NetProfit);

    if (totalProfit > 1000)
    {
        foreach (var position in buyPositions)
        {
            ClosePosition(position);
        }
    }
}

This will check for the condition on each price change or tick of data, you can find out more about LINQ below.

https://www.tutorialsteacher.com/linq/what-is-linq

Jiggy

Hi,
Many thanks for your help, it does clarify a lot. Greatly appreciated.

debongos

I used this code on a number of trading bots running simultaneously but with different labels. Individually they tested well so I ran them all live. It seems all trades for all labels were closed at some point.

Could you confirm if this code will only close buy trades for a label named in the bot and not all buy trades for all bots regardless of label name.

debongos

May have found the problem. As per below I had added some lines to include the sum of sell positions however, I was closing all positions for a label when the sum of buy trades was in net profit or the sum sell trades were in net profit. Either way, I was closing all positions without first checking that the sum of both trade types had (overall) a net profit.

Still not sure if the below code would affect other bots using a different Label but any suggestions is appreciated.

        var positions = Positions.FindAll(label);
        var buyPositions = positions.Where(x => x.TradeType == TradeType.Buy);
        var sellPositions = positions.Where(x => x.TradeType == TradeType.Sell);
        double totalProfit = buyPositions.Sum(x => x.NetProfit);
        double totalProfit2 = sellPositions.Sum(x => x.NetProfit);

        if (totalProfit > BuyNett)
        {
            foreach (var position in Positions)
            {
                ClosePosition(position);
            }
        }

        if (totalProfit2 > SellNett)
        {
            foreach (var position in Positions)
            {
                ClosePosition(position);
            }
        }

debongos

This is my updated version.

         [Parameter("Nett Profit", Group = "Nett Profits", DefaultValue = 0, MinValue = 0, MaxValue = 1000)]
         public int NettP { get; set; }
         protected override void OnTick()
         
        {
        var positions = Positions.FindAll(label);
        var buyPositions = positions.Where(x => x.TradeType == TradeType.Buy);
        var sellPositions = positions.Where(x => x.TradeType == TradeType.Sell);
        double totalProfit = buyPositions.Sum(x => x.NetProfit);
        double totalProfit2 = sellPositions.Sum(x => x.NetProfit);

        if ((totalProfit + totalProfit2) > NettP)
        {
            foreach (var position in Positions)
            {
                ClosePosition(position);
            }
        }
    }

Mike

Hi,

The 1st line of code will only return positions that match the label name.

var positions = Positions.FindAll(label);

all the calculations are for the filtered positions by label name.

The foreach statement will close all open positions, but if you wish to only close positions filtered by the label name, use this.

foreach (var p in positions)
{
       ClosePosition(p);
}

sparky

Hi Mike.

This was an excellent original question and I have found your answers to be excellent knowledge. It was very close to the final problem I have struggled with in my cbot.

However if I try to use this code and finish with the final foreach statement shown above to just close the labelled positions I encounter four errors:

; expected
; expected
} expected
No overload method for ClosePosition

These all occur on the ClosePosition()p); line.

I hope you can help with this as it is perplexing me!

Mike

Use

ClosePosition(p);

Sorry, for my code mistake :-)