cTrader Instance Name in cBot

marky

Hi,
I want to add parameter ‘Instance Name’ to a cBot (below is code). This will avoid problems if same trading instrument with different timeframes is used by other cBot instances.

I know I can add below 2 lines in the start of code, but what else shall I change in later part of the code to make it work?

[Parameter("Instance Name", DefaultValue = "0123")]
public string Label { get; set; }

I am new to coding, so I will appreciate if someone can help to add 'Instance Name' in below code, and send updated code to me. Thank you.

using cAlgo.API;
using cAlgo.API.Indicators;

namespace cAlgo.Robots
{
    [Robot(AccessRights = AccessRights.None)]
    public class RsiMa : Robot
    {
        private Position _position;
        private MovingAverage ma;
        private RelativeStrengthIndex rsi;

        [Parameter("Source")]
        public DataSeries Source { get; set; }

        [Parameter("RSI Periods", DefaultValue = 14)]
        public int Periods { get; set; }

        [Parameter("RSI Overbought", DefaultValue = 70)]
        public int Overbought { get; set; }

        [Parameter("RSI Oversold", DefaultValue = 30)]
        public int Oversold { get; set; }

        [Parameter("MA Period", DefaultValue = 200)]
        public int MAPeriod { get; set; }

        [Parameter("Volume", DefaultValue = 1000, MinValue = 0)]
        public int Volume { get; set; }

        [Parameter("MA Type")]
        public MovingAverageType MAType { get; set; }

        protected override void OnStart()
        {
            rsi = Indicators.RelativeStrengthIndex(Source, Periods);
            ma = Indicators.MovingAverage(Source, MAPeriod, MAType);
        }

        protected override void OnBar()
        {
            if (Trade.IsExecuting)
                return;

            if (rsi.Result.LastValue < Oversold && (ma.Result.LastValue < MarketSeries.Close.LastValue) && _position == null)
            {
                OpenPosition(TradeType.Buy);
            }

            if (rsi.Result.LastValue > Overbought && (ma.Result.LastValue > MarketSeries.Close.LastValue) && _position == null)
            {
                OpenPosition(TradeType.Sell);
            }
            if (_position != null)
            {
                if (_position.TradeType == TradeType.Buy && rsi.Result.LastValue > Overbought)
                {
                    Trade.Close(_position);
                }

                if (_position.TradeType == TradeType.Sell && rsi.Result.LastValue < Oversold)
                {
                    Trade.Close(_position);
                }
            }
        }

        private void OpenPosition(TradeType command)
        {
            Trade.CreateMarketOrder(command, Symbol, Volume);
        }

        protected override void OnPositionOpened(Position openedPosition)
        {
            _position = openedPosition;
        }

        protected override void OnPositionClosed(Position closedPosition)
        {
            _position = null;
        }
    }
}

Mike

Hi, Marky,

First you add the new parameter:

[Parameter("Instance Name", DefaultValue = "0123")]
public string Label { get; set; }

.
Then in the OnPositionOpened method, you need to test that it is using your custom instance name., so that other symbols are not managed by this bot.

if(openedPosition.Label == Label && openedPosition.SymbolName == SymbolName)
{
   _position = openedPosition_
}

This would filter only trades using the unique label name and same symbol name.

marky

Thanks Mike for reply. Can I please please request from you to add them in the correct place in the long code above? and send back to me the entire code?

I am sorry to ask this (especially because its free help), but I can't get my head around this. The original code is written by someone else, I just needed to add Instance name at correct place in the code. Thank you

I am planning to learn coding from clickalgo, but in the meantime needed to run this bot on VPS, so I will appreciate if you can add Instance name in the correct place, and send to me the entire code. Thanks

Mike

Hi, Marky, this free service is to help traders learn to code, this is why we provide code snippet help instead of coding for the customer, our future algorithmic coding school will follow the same guidelines, just add the following code block where you have all your other parameters listed.

[[Parameter("Instance Name", DefaultValue = "0123")]
public string Label { get; set; }

And add this code block to the method onPositionedOpened replacing the existing code.

if(openedPosition.Label == Label && openedPosition.SymbolName == SymbolName)
{
   _position = openedPosition_
}

Admin

Here is the complete solution, just copy the code and paste it into the cBot.

using cAlgo.API;
using cAlgo.API.Indicators;

namespace cAlgo.Robots
{
    [Robot(AccessRights = AccessRights.None)]
    public class RsiMa : Robot
    {
        private Position _position;
        private MovingAverage ma;
        private RelativeStrengthIndex rsi;

        [Parameter("Instance Name", DefaultValue = "0123")]
        public string Label { get; set; }

        [Parameter("Source")]
        public DataSeries Source { get; set; }

        [Parameter("RSI Periods", DefaultValue = 14)]
        public int Periods { get; set; }

        [Parameter("RSI Overbought", DefaultValue = 70)]
        public int Overbought { get; set; }

        [Parameter("RSI Oversold", DefaultValue = 30)]
        public int Oversold { get; set; }

        [Parameter("MA Period", DefaultValue = 200)]
        public int MAPeriod { get; set; }

        [Parameter("Volume", DefaultValue = 1000, MinValue = 0)]
        public int Volume { get; set; }

        [Parameter("MA Type")]
        public MovingAverageType MAType { get; set; }

        protected override void OnStart()
        {
            rsi = Indicators.RelativeStrengthIndex(Source, Periods);
            ma = Indicators.MovingAverage(Source, MAPeriod, MAType);
        }

        protected override void OnBar()
        {
            if (Trade.IsExecuting)
                return;

            if (rsi.Result.LastValue < Oversold && (ma.Result.LastValue < MarketSeries.Close.LastValue) && _position == null)
            {
                OpenPosition(TradeType.Buy);
            }

            if (rsi.Result.LastValue > Overbought && (ma.Result.LastValue > MarketSeries.Close.LastValue) && _position == null)
            {
                OpenPosition(TradeType.Sell);
            }
            if (_position != null)
            {
                if (_position.TradeType == TradeType.Buy && rsi.Result.LastValue > Overbought)
                {
                    Trade.Close(_position);
                }

                if (_position.TradeType == TradeType.Sell && rsi.Result.LastValue < Oversold)
                {
                    Trade.Close(_position);
                }
            }
        }

        private void OpenPosition(TradeType command)
        {
            Trade.CreateMarketOrder(command, Symbol, Volume);
        }

        protected override void OnPositionOpened(Position openedPosition)
        {
            if (openedPosition.Label == Label && openedPosition.SymbolName == SymbolName)
            {
                _position = openedPosition;
            }
        }

        protected override void OnPositionClosed(Position closedPosition)
        {
            _position = null;
        }
    }
}

Admin

I would test this cBot on a demo account until you are happy your new feature is working correctly.

marky

Thanks. The previous code was working perfectly, but after this new code added, positions are not being closed. All positions are accumulating as open positions. Something went wrong while adding Instance name

Admin

Looks like the bot is using legacy code, it still works, but some features like filtering by label did not work.

This was added to the OnStart method, the new method is to subscribe to the events.

protected override void OnStart()
{
    rsi = Indicators.RelativeStrengthIndex(Source, Periods);
    ma = Indicators.MovingAverage(Source, MAPeriod, MAType);

    Positions.Opened += Positions_Opened;
    Positions.Closed += Positions_Closed;
}

This was added to the project replacing the opened and closed position event methods.

private void OpenPosition(TradeType command)
{
    //Trade.CreateMarketOrder(command, Symbol, Volume, Label);
    ExecuteMarketOrder(command, SymbolName, Volume, Label);
}

private void Positions_Opened(PositionOpenedEventArgs obj)
{
    Print(obj.Position.Label);
    if (obj.Position.Label == Label && obj.Position.SymbolName == SymbolName)
    {
        _position = obj.Position;
    }
}

A new method ExecuteMarketOrder is used to submit a market order and include the label.

Here is the complete source code.

using cAlgo.API;
using cAlgo.API.Indicators;

namespace cAlgo.Robots
{
    [Robot(AccessRights = AccessRights.None)]
    public class RsiMa : Robot
    {
        private Position _position;
        private MovingAverage ma;
        private RelativeStrengthIndex rsi;

        [Parameter("Instance Name", DefaultValue = "0123")]
        public string Label { get; set; }

        [Parameter("Source")]
        public DataSeries Source { get; set; }

        [Parameter("RSI Periods", DefaultValue = 14)]
        public int Periods { get; set; }

        [Parameter("RSI Overbought", DefaultValue = 70)]
        public int Overbought { get; set; }

        [Parameter("RSI Oversold", DefaultValue = 30)]
        public int Oversold { get; set; }

        [Parameter("MA Period", DefaultValue = 200)]
        public int MAPeriod { get; set; }

        [Parameter("Volume", DefaultValue = 1000, MinValue = 0)]
        public int Volume { get; set; }

        [Parameter("MA Type")]
        public MovingAverageType MAType { get; set; }

        protected override void OnStart()
        {
            rsi = Indicators.RelativeStrengthIndex(Source, Periods);
            ma = Indicators.MovingAverage(Source, MAPeriod, MAType);

            Positions.Opened += Positions_Opened;
            Positions.Closed += Positions_Closed;
        }

        protected override void OnBar()
        {
            if (Trade.IsExecuting)
                return;

            if (rsi.Result.LastValue < Oversold && (ma.Result.LastValue < MarketSeries.Close.LastValue) && _position == null)
            {
                OpenPosition(TradeType.Buy);
            }

            if (rsi.Result.LastValue > Overbought && (ma.Result.LastValue > MarketSeries.Close.LastValue) && _position == null)
            {
                OpenPosition(TradeType.Sell);
            }
            if (_position != null)
            {
                if (_position.TradeType == TradeType.Buy && rsi.Result.LastValue > Overbought)
                {
                    Trade.Close(_position);
                }

                if (_position.TradeType == TradeType.Sell && rsi.Result.LastValue < Oversold)
                {
                    Trade.Close(_position);
                }
            }
        }

        private void OpenPosition(TradeType command)
        {
            //Trade.CreateMarketOrder(command, Symbol, Volume, Label);
            ExecuteMarketOrder(command, SymbolName, Volume, Label);
        }

        private void Positions_Opened(PositionOpenedEventArgs obj)
        {
            if (obj.Position.Label == Label && obj.Position.SymbolName == SymbolName)
            {
                _position = obj.Position;
            }
        }

        private void Positions_Closed(PositionClosedEventArgs obj)
        {
            _position = null;
        }
    }
}

Admin

I backtested over 1-year and it worked fine, again I would run it on a demo account until you are happy it is working ok, if you have any further coding questions please post a new thread unless it is related to the instance label feature.

marky

Thanks Admin, you are amazing. I will definitely use Clickalgo for future needs and learning coding.
Sorry for being bit pushy, but I do understand your point of view.
Keep doing amazing work. God bless you.

Admin

Thank you Marky, I will review also how we help customers with coding questions.

marky

If you want, its ok for me if you want to delete this entire post here. I mean, I do understand what you mean earlier. Thanks again

marky

Hi, you mentioned that previous bot was using legacy code. To add ''Instance Name' to newer code, example in below code ''Sample RSI cBot', which is included in ctrader by default.

But I can't find OnPositionOpened method in this code.
How can I add Instance Name in below code? to be able to run multiple cBot instances on same symbol.

using System;
using System.Linq;
using cAlgo.API;
using cAlgo.API.Indicators;
using cAlgo.API.Internals;
using cAlgo.Indicators;

namespace cAlgo
{
[Robot(TimeZone = TimeZones.UTC, AccessRights = AccessRights.None)]
public class SampleRSIModified : Robot
{

    [Parameter("Quantity (Lots)", Group = "Volume", DefaultValue = 1, MinValue = 0.01, Step = 0.01)]
    public double Quantity { get; set; }

    [Parameter("Source", Group = "RSI")]
    public DataSeries Source { get; set; }

    [Parameter("Periods", Group = "RSI", DefaultValue = 14)]
    public int Periods { get; set; }

    [Parameter("Lower RSI Level", Group = "RSI", DefaultValue = 30, MinValue = 0, MaxValue = 50)]
    public int LRL { get; set; }

    [Parameter("Upper RSI Level", Group = "RSI", DefaultValue = 70, MinValue = 50, MaxValue = 100)]
    public int URL { get; set; }

    [Parameter("Take Profit in pips", Group = "TP SL", DefaultValue = 100)]
    public int TP { get; set; }

    [Parameter("Stop Loss in pips", Group = "TP SL", DefaultValue = 100)]
    public int SL { get; set; }

    private RelativeStrengthIndex rsi;

    protected override void OnStart()
    {
        rsi = Indicators.RelativeStrengthIndex(Source, Periods);
    }

    protected override void OnTick()
    {
        if (rsi.Result.LastValue < LRL)
        {
            Close(TradeType.Sell);
            Open(TradeType.Buy);
        }
        else if (rsi.Result.LastValue > URL)
        {
            Close(TradeType.Buy);
            Open(TradeType.Sell);
        }
    }

    private void Close(TradeType tradeType)
    {
        foreach (var position in Positions.FindAll("SampleRSI", SymbolName, tradeType))
            ClosePosition(position);
    }

    private void Open(TradeType tradeType)
    {
        var position = Positions.Find("SampleRSI", SymbolName, tradeType);
        var volumeInUnits = Symbol.QuantityToVolumeInUnits(Quantity);

        if (position == null)
            ExecuteMarketOrder(tradeType, SymbolName, volumeInUnits, "SampleRSI", SL, TP);
    }
}

}

marky

@Admin#1869 I backtested over 1-year and it worked fine, again I would run it on a demo account until you are happy it is working ok, if you have any further coding questions please post a new thread unless it is related to the instance label feature.

Hi Admin, since you added instance name in code, bot doesn't open any new positions. It only shows results in backtest, but doesn't open positions in real time.
Just imagine now, you guys are expert, even then adding instance name became a challenge, and Mike tried to show as if he did something great by writing one line of code, without considering anything else !!
You don't have to think about correcting this problem anymore, I asked someone on another forum, and they fixed in 5 minutes, and also didn't show as if they did a big favor. Most traders and coders are happy to share knowledge because that's their passion, but some only help if they get money. Just my opinion.
I hope you guys don't delete genuine conversation, and wrongly blame its abusive behavior.
Good luck

Note: My suggestion: if you guys are short of time (and passion) to help on coding issues, its better to not ask people to post their questions and saying you will solve for free). Thanks again Admin for your initiative though.