Custom Indicator referencing problem with parameters

sparky

I have written a simple custom Indicator:

 _ema = Indicators.ExponentialMovingAverage(Source, Period);
 _ema1 = Indicators.ExponentialMovingAverage(Source, Period1);

And I referenced it in my algorithm:

_diff = Indicators.GetIndicator<Difference>(Bars.ClosePrices);

but as soon as I add a condition:

_diff.Result.Last() > DMAX &&

I get an error in Backtest:

Crashed in OnStart with ArgumentException: Incorrect parameters count. Parameter name: parameterValues

I understand that it is me not defining the right parameters, but am unsure what I am missing as everything else is defined in the Indicator itself?

Mike

Hi, Sparky, can you edit your post above and highlight all the code text and use the insert code option to correctly add the source code?

sparky

Hi Mike

I did use the insert code option for all of the code and that is how it comes out.

I have tried a few times using the insert code link and putting all code in between the two '' that come up but it always puts some out of the box as normal text and then some in the code box.

If you can help to explain why it is doing this and what I need to do to make all of the code appear in the code box I will do it, but unfortunately I could not get it to work on previous posts or this one.

Regards

Mike

I will do it for you again, you simply highlight all the code text and then click on the insert code icon in the code editor window, edit your original post to see the characters it adds to the start and end of the code block.

Also, you only need to provider the sample code and not all of it or half of it.

sparky

Ah I see. I was doing it the wrong way around by clicking the insert code and then pasting the code in as I wrote the post.

I shall remember this for any future posts.

Many thanks for the help in understanding

Mike

no worries, go and look at the source code for the indicator Difference, you need the same parameter setting values, also you do not need to pass in the close prices I think. If this does not help share the parameter settings for the indicator here.

sparky

Thank you for the reply.

I tried to set the same indicator parameters in the algorithm and I got the following error:

Crashed in OnStart with AlgoActivationException: Can not set "DataSeries (Count: 4322, LastValue: 1.33862)" as a value for "Periods" parameter

I understand this to be a reference to the Indicator parameter.

The indicator parameters are:



        [Parameter("Periods", DefaultValue = 22)]
        public int Periods { get; set; }

        [Parameter("Period1", DefaultValue = 50)]
        public int Period1 { get; set; }

        [Parameter("Source")]
        public DataSeries Source { get; set; }

Mike

The parameters of the indicator must match your indicator construction in your cbot.

It should be

_diff = Indicators.GetIndicator<Difference>(22, 50);

Yoy may need the source also as a parameter, not sure, if you need more help take a look at the official Spotware help guide.

https://help.ctrader.com/ctrader-automate/guides/indicators/

sparky

I have tried this and it does not work bit gives the error highlighted above.

Mike

You could share the indicator and cBot code as a text file upload so the community can help.

https://clickalgo.com/upload-bug-reoprts